armored: harden image integrity check against fault injections#812
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens wolfBoot’s image integrity verification against fault-injection attacks by adding redundant digest comparison logic and additional hardened sanity checks to ensure integrity is confirmed before signature verification proceeds.
Changes:
- Replace the single digest compare in
wolfBoot_verify_integrity()with a hardened comparison macro and a hardened success condition. - Add new ARMORED integrity state redundancy (
not_sha_ok,canary_FEEDCAFE) plus helper setters/clearers instruct wolfBoot_image. - Add
SHA_SANITY_CHECK()inwolfBoot_verify_authenticity()to assert integrity in a fault-hardened way before signature verification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/image.c | Switch integrity verification to a redundant/hardened comparison flow and add an integrity sanity check before authenticity verification continues. |
| include/image.h | Extend ARMORED integrity state with redundant flags/canaries and add hardened macros for integrity verification and integrity sanity checking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zd22067